karlender: 0.9.2 -> 0.10.3 #242295
Open
karlender: 0.9.2 -> 0.10.3 #242295
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
doronbehar
requested changes
Sep 9, 2023
| , tzdata | ||
| }: | ||
|
|
||
| let | ||
| cargo-gra = rustPlatform.buildRustPackage rec { |
There was a problem hiding this comment.
Maybe this package should be added in all-packages.nix?
| cargo gra gen | ||
| ''; | ||
|
|
||
| # test domain::time::tests::test_get_correct_offset_for_dst ... FAILED |
There was a problem hiding this comment.
I think it's possible to disable only a single test. Could you verify that? and perhaps look up for upstream reports about this failure, and ideally link to such a report in a comment.
wegank
added
the
2.status: stale
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)