Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu-config: add cannot-use-fetchpatch comment #237966

Merged
merged 1 commit into from Jun 16, 2023
Merged

gnu-config: add cannot-use-fetchpatch comment #237966

merged 1 commit into from Jun 16, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2023

Description of changes

gnu-config is used by updateAutotoolsGnuConfigScriptsHook, which is used by stdenv.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

gnu-config is used by updateAutotoolsGnuConfigScriptsHook, which is
used by stdenv.
@wegank wegank merged commit afc3a71 into NixOS:master Jun 16, 2023
@ghost ghost deleted the pr/gnu-config/scary-warning branch June 18, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant