Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: fix crossSystem localSystem comparison #237427

Closed
wants to merge 3 commits into from

Commits on Jun 15, 2023

  1. stdenv: fix crossSystem localSystem comparison

    this appears to fix the following issue for some reason
    
    ```
    nix-repl> (import ./. { localSystem.system = "x86_64-linux"; crossSystem.system = "x86_64-linux"; }).bash
    «derivation /nix/store/5lz9p8xhf89kb1c1kk6jxrzskaiygnlh-bash-5.2-p15.drv»
    
    nix-repl> (import ./. { localSystem.system = "x86_64-linux"; crossSystem = "x86_64-linux"; }).bash
    «derivation /nix/store/1whiq03rsfrmch2ds3jhyqjaczfz97lb-bash-5.2-p15-x86_64-unknown-linux-gnu.drv»
    ```
    
    fixed
    ```
    nix-repl> (import ./. { localSystem.system = "x86_64-linux"; crossSystem = "x86_64-linux"; }).bash
    «derivation /nix/store/5lz9p8xhf89kb1c1kk6jxrzskaiygnlh-bash-5.2-p15.drv»
    ```
    Artturin committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    e5e5fd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e32b2a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. pkgs/top-level: Improve crossSystem equality early on

    This is a workaround that lets us use `==` on systems despite the
    functions that would make `==` always return `false` if a
    workaround like this is not applied.
    
    The real solution is to either use `lib.systems.equals` for all
    such comparisons, or to remove all functions from the elaborated
    systems.
    roberth committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    87c34c6 View commit details
    Browse the repository at this point in the history