Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustPlatform.importCargoLock: use fetchCrate #234650

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

rustPlatform.importCargoLock: use fetchCrate #234650

wants to merge 1 commit into from

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented May 28, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@figsoda figsoda requested review from zowoq and winterqt as code owners May 28, 2023 17:22
@figsoda
Copy link
Member Author

figsoda commented Jun 30, 2023

oops I did not mean to target master

@figsoda figsoda marked this pull request as draft June 30, 2023 01:28
@figsoda figsoda changed the base branch from master to staging June 30, 2023 01:30
@figsoda figsoda marked this pull request as ready for review June 30, 2023 01:30
@figsoda
Copy link
Member Author

figsoda commented Aug 26, 2023

@ofborg eval

I forgot I had this open, re-evaluating to make sure nothing has changed in the few months

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@FliegendeWurst
Copy link
Member

Now that we have #349360, I don't think we need this anymore

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 17, 2024
@TomaSajt
Copy link
Contributor

Now that we have #349360, I don't think we need this anymore

importCargoLock is not going away since it has its own benefits out of tree, so I don't think we should say that improvements to it are not needed

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq Awaiting requested review from zowoq

@winterqt winterqt Awaiting requested review from winterqt

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: rust 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@figsoda @FliegendeWurst @TomaSajt @wegank