-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fmt: 9.1.0 -> 10.0.0 #233330
fmt: 9.1.0 -> 10.0.0 #233330
Conversation
Clasp is not compatible with fmt 10 yet.
Result of 2 packages marked as broken and skipped:
243 packages failed to build:
60 packages built:
|
spdlog has patches upstream: gabime/spdlog#2694 gabime/spdlog#2736 |
Result of 41 packages marked as broken and skipped:
169 packages failed to build:
97 packages built:
|
This is laying around for around a month now with no further complains and two approvals so I will merge this. |
So, as the nixpkgs-review above suggested, this broke lots of packages, apparently most of this diff: |
Uff I'm sorry 😔 |
Sorry about that, I totally forgot about reviewing the failures. I think we can solve most the breakages by pinning spdlog to fmt 9 #240270 |
I've got another PR to fix a build failure here: #240338 |
Fix for coeurl (nheko dependency) is in #240698 . |
iptsd package is not building too with an error mentioning this. |
Sorry about that, iptsd should be fixed by #241229 |
Description of changes
https://github.com/fmtlib/fmt/releases/tag/10.0.0
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)