Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schildichat-desktop: use electron 24.x #232441

Merged
merged 1 commit into from
May 17, 2023
Merged

schildichat-desktop: use electron 24.x #232441

merged 1 commit into from
May 17, 2023

Conversation

yu-re-ka
Copy link
Contributor

Description of changes

As pinned by upstream:

https://github.com/SchildiChat/element-desktop/blob/2f54ef60617db8b5d4a8acdb3ae90721d05de3b3/package.json#L91

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yu-re-ka yu-re-ka changed the title schildichat-deskotp: use electron 24.x schildichat-desktop: use electron 24.x May 17, 2023
@yayayayaka
Copy link
Member

Result of nixpkgs-review pr 232441 run on x86_64-linux 1

2 packages built:
  • schildichat-desktop
  • schildichat-desktop-wayland

Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested schildichat-desktop on x86_64-linux. LGTM

@yu-re-ka yu-re-ka merged commit 0e29625 into NixOS:master May 17, 2023
@yu-re-ka yu-re-ka deleted the schildi-electron-24 branch May 17, 2023 17:00
@github-actions
Copy link
Contributor

Successfully created backport PR for release-22.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants