Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrfconnect: 3.11.1 -> 4.0.1 #229299

Merged
merged 1 commit into from
May 2, 2023
Merged

nrfconnect: 3.11.1 -> 4.0.1 #229299

merged 1 commit into from
May 2, 2023

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented May 1, 2023

Description of changes

Updated to latest nrfconnect

Things done

Updated and tested

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 1, 2023
@wegank
Copy link
Member

wegank commented May 1, 2023

Looks good, but is it a breaking change?

@eyJhb
Copy link
Member Author

eyJhb commented May 1, 2023

Unsure, each time I open up the current version (3.x), it says that most of the tools are only supported by 4.x :)

@wegank
Copy link
Member

wegank commented May 1, 2023

So it looks like it doesn't quite work on version 3.x, I guess.

Does the version upgrade require any manual migration on the user side? If not, this PR should be good for merging.

@eyJhb
Copy link
Member Author

eyJhb commented May 2, 2023

Sadly I have no clue @wegank , I would assume that nrfconnect would prompt if anything needs to happen.
I just started using this software, and are not all that into how it should behave etc.

I just know that I can now use the Power Profiler :D But this package hasn't been touched since it was first init, so I would assume that not too many use it (might be a bad assumption).

@wegank wegank merged commit 1a411f2 into NixOS:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants