Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clonehero: 0.23.2.2 -> 1.0.0.4080 #228096

Closed
wants to merge 1 commit into from
Closed

clonehero: 0.23.2.2 -> 1.0.0.4080 #228096

wants to merge 1 commit into from

Conversation

syboxez
Copy link

@syboxez syboxez commented Apr 25, 2023 •
edited
Loading

Description of changes

Final release of Clone Hero
https://clonehero.net/releases/v1.0.0.4080/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

NOTE: Package is currently broken, but builds fine. Running the binary crashes with no error. Marking PR as Draft until it runs.

@syboxez syboxez changed the title clonehero: 0.23.2.2 -> 1.0.0.4080-final clonehero: 0.23.2.2 -> 1.0.0.4080 Apr 25, 2023
@ofborg ofborg bot requested a review from kira-bruneau April 25, 2023 07:34
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 25, 2023
@kira-bruneau kira-bruneau mentioned this pull request May 1, 2023
Merged
12 tasks
@kira-bruneau
Copy link
Contributor

kira-bruneau commented May 1, 2023 •
edited
Loading

Thanks @syboxez!! I managed to get this working and opened a new PR for it: #229321

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
@kira-bruneau
Copy link
Contributor

Superseded by #229321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kira-bruneau kira-bruneau Awaiting requested review from kira-bruneau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syboxez @kira-bruneau @Janik-Haag