gpgme: fix cross, drop python2 #226123
Merged
gpgme: fix cross, drop python2 #226123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: cross-compilation
Mindavi
reviewed
Apr 14, 2023
| @@ -51,12 +50,16 @@ stdenv.mkDerivation rec { | |||
| pkg-config | |||
| texinfo | |||
| ] ++ lib.optionals pythonSupport [ | |||
| buildPackages.python3 | |||
There was a problem hiding this comment.
Shouldn't this be in depsBuildBuild instead then?
There was a problem hiding this comment.
I think the whole splicing thing needs to be rethought/redone.
dotlambda
requested changes
Apr 14, 2023
It takes |
ghost
requested a review
from 
This package very confusingly takes both python(2) and python3 as arguments, and then mixes them up via an overlay in python-packages. Since python2 is now marked INSECURE, let's just stick with python3. Also fixes cross compilation.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package very confusingly takes both python(2) and python3 as
arguments, and then mixes them up via an overlay in python-packages.
Since python2 is now marked INSECURE, let's just stick with python3.
Also fixes cross compilation.