Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: pass nixpkgs-revision instead of nixpkgs #226061

Closed
wants to merge 1 commit into from
Closed

doc: pass nixpkgs-revision instead of nixpkgs #226061

wants to merge 1 commit into from

Commits on Apr 13, 2023

  1. doc: pass nixpkgs-revision instead of nixpkgs 

    The `doc` expressions take both a `pkgs` packageset as well as a
`nixpkgs` argument whose purpose is unclear.

I traced all the usage of `nixpkgs` and it appears to be simply "any
attrset with a `revision` attribute".  Let's replace this argument
with `nixpkgs-revision` so people know what its purpose is.

I did not change the arguments to `doc/default.nix` because it might
be considered an exposed public interface (does Hydra
`nix-instantiate` it directly?).  We should give it an entry in
all-packages.nix and access it that way.
    Adam Joseph committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ca08ad1 View commit details
    Browse the repository at this point in the history