doc: Fix the function locations always pointing to master #226057
Conversation
Instead of revisions as they should. This is (most-likely) caused by a simple typo, because Hydra is where the revision should come from, but it doesn't set `.revision` as the attribute, but rather `.rev`!
There was a problem hiding this comment.
because Hydra is where the revision should come from
Actually, the manual is built directly from the flake (nixpkgs#htmlDocs.nixpkgsManual): check out https://github.com/NixOS/nixos-homepage/blob/master/flake.nix#L137 (the inputs are updated hourly). But Nix indeed sets rev, not revision, so this fixes it.
Ideally we should probably point to the stable branch instead of the specific revision, which #203994 does, but I've lost all motivation to work on that.
|
Ah nice, thanks for the info! I also subscribed to that PR, though I don't have any time to look at it now. I'll merge this PR |
|
Can confirm, this fixed #223404 :) |
|
@infinisil how did you confirm this fixes it? I can still see a link to Is this fixed for |
|
Successfully created backport PR for |
|
Should be fixed next time |
|
@asymmetric Yes it's only fixed in unstable, check out https://nixos.org/manual/nixpkgs/unstable/#sec-functions-library-asserts |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-04-20-documentation-team-meeting-notes-42/27470/1 |
Instead of revisions as they should. This is (most-likely) caused by a simple typo, because Hydra is where the revision should come from, but it doesn't set
.revisionas the attribute, but rather.rev! This comes from https://github.com/NixOS/hydra/blob/082495e34e094cae1eb49dbfc5648938e23c6355/src/script/hydra-eval-jobset#L300-L301Fixes #223404
I can't actually verify this, but everything points to this being the problem, we'll have to check whether this worked when Hydra completes the next manual build.
This work is sponsored by Antithesis ✨