Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all-packages.nix: expose arm-trusted-firmware #225537

Merged
1 commit merged into from Apr 15, 2023
Merged

all-packages.nix: expose arm-trusted-firmware #225537

1 commit merged into from Apr 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2023

Description of changes

This commit exposes

arm-trusted-firmware = callPackage ../misc/arm-trusted-firmware { }

at the top level. Without this it is impossible for downstream users like ownerboot to override options like unfreeIncludeHDCPBlob and dependencies like openssl (remind me again why people think openssl in their bootloader is a good idea? i've been overriding this to null for ages and nothing breaks....)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This commit exposes

```
  arm-trusted-firmware = callPackage ../misc/arm-trusted-firmware { }
```

at the top level.  Without this it is impossible for downstream
users like [ownerboot](https://git.sr.ht/~amjoseph/ownerboot) to
override options like `unfreeIncludeHDCPBlob` and dependencies like
`openssl`.
@ghost ghost merged commit 9d42684 into NixOS:master Apr 15, 2023
@ghost ghost deleted the pr/arm-trusted-firmware/expose-top-level branch April 15, 2023 17:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant