Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.xorgserver: fixup build on *-darwin #219852

Merged
merged 1 commit into from
Mar 6, 2023
Merged

xorg.xorgserver: fixup build on *-darwin #219852

merged 1 commit into from
Mar 6, 2023

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Mar 6, 2023 •
edited
Loading

Broken by the update in be54beb.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Mar 6, 2023
@vcunat vcunat mentioned this pull request Mar 6, 2023
Merged
13 tasks
@vcunat
Copy link
Member Author

vcunat commented Mar 6, 2023

I have no idea if xorg.xorgserver is useful on *-darwin, though.

@wegank
Copy link
Member

wegank commented Mar 6, 2023 •
edited
Loading

@ofborg build xorg.xorgserver

Atemu
Atemu approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully builds

python310Packages.xvfbwrapper python311Packages.xvfbwrapper xorg.xinit xorg.xorgserver xquartz

on aarch64-darwin.

I don't know how useful that is though; we probably shouldn't spend our time on this.

@wegank
Copy link
Member

wegank commented Mar 6, 2023 •
edited
Loading

Also built xorg.xorgserver with/without sandbox (maybe I was wrong?) on aarch64-darwin, I don't know why ofborg fails.

EDIT: the failure is still not reproducible on my machine...

@mweinelt
Copy link
Member

mweinelt commented Mar 6, 2023 •
edited
Loading

Yep, also builds for me on aarch64-darwin. Let's call it a fluke and give hydra shot.

@mweinelt mweinelt merged commit 8127b7c into NixOS:master Mar 6, 2023
@vcunat vcunat deleted the p/xorgserver-darwin branch March 6, 2023 19:53
@vcunat
Copy link
Member Author

vcunat commented Mar 8, 2023

Well, the xcode errors do reproduce on Hydra:
https://hydra.nixos.org/build/211742341
https://hydra.nixos.org/build/211741717

@wegank wegank mentioned this pull request Mar 8, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vcunat @wegank @mweinelt @Atemu