Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql: enable more features #218934

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

poscat0x04
Copy link
Contributor

Description of changes

Enabled the following features:

  • ldap auth
  • pam auth
  • llvm JIT
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

features enabled: openldap, pam, llvm
@risicle
Copy link
Contributor

risicle commented Mar 4, 2023

This might be the fourth(?) attempt at enabling the postgres JIT. Please see previous PRs #124804, #150801 and probably more. cc @andir @abbradar @RaitoBezarius @marsam

@RaitoBezarius
Copy link
Member

This might be the fourth(?) attempt at enabling the postgres JIT. Please see previous PRs #124804, #150801 and probably more. cc @andir @abbradar @RaitoBezarius @marsam

Thank you for the triage, I suggest we try to get #150801 in shape, @poscat0x04 if that's okay with you, this should take care of the JIT part of this PR.

Then, we can examine the rest separately.

I can already tell unfortunately this PR has troubles with the WAL receiver test, see https://github.com/NixOS/nixpkgs/pull/218934/checks?check_run_id=11676876625

@kirillrdy
Copy link
Member

jit support has been merged as part of #221851

"--with-openssl"
"--with-libxml"
"--with-icu"
"--sysconfdir=/etc"
"--libdir=$(lib)/lib"
"--with-system-tzdata=${tzdata}/share/zoneinfo"
"--enable-debug"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing that should come with a motivation.

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants