Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_git: switch to using ninja #218620

Merged
merged 2 commits into from
Feb 27, 2023
Merged

llvmPackages_git: switch to using ninja #218620

merged 2 commits into from
Feb 27, 2023

Conversation

alyssais
Copy link
Member

Description of changes

Ports of 4d3857d and 912056c.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
llvmPackages_git: expand the NIX_BUILD_CORES arg passed to lit at c…
022380b 
…onfigure time

Port of 4d3857d ("llvmPackages_15: expand the `NIX_BUILD_CORES`
arg passed to lit at configure time").
@alyssais
llvmPackages_git: switch to using ninja
391f823 
Port of 912056c ("llvmPackages_15: switch to using `ninja`").
@alyssais alyssais merged commit 60a2f64 into NixOS:staging Feb 27, 2023
@alyssais alyssais deleted the llvmPackages_git-ninja branch February 27, 2023 16:12
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@rrbutani rrbutani rrbutani approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alyssais @sternenseemann @rrbutani