Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baresip: use cmake for configurePhase, fixes cross #218525

Merged
6 commits merged into from Mar 21, 2023
Merged

baresip: use cmake for configurePhase, fixes cross #218525

6 commits merged into from Mar 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 26, 2023

Description of changes

Although baresip is a cmake-based project, our expression was not using cmake for the configurePhase. This commit causes it to do so, which fixes cross-compilation for this package.

Incorporates:

Closes #220762

Things done
  • Built on platform(s)
    • aarch64-linux (cross from x86_64-linux)

Adam Joseph added 6 commits February 26, 2023 14:57
Although libre is a cmake-based project, our expression for this
library does not currently use cmake for the configurePhase.  This
commit causes it to do so.

This is necessary to get downstream libre and baresip to cross-compile.
Although librem is a cmake-based project, our expression for this
library does not currently use cmake for the configurePhase.  This
commit causes it to do so.

This is necessary to get downstream libre and baresip to cross-compile.
Although baresip is a cmake-based project, our expression was not
using cmake for the configurePhase.  This commit causes it to do so,
which fixes cross-compilation for this package.

Incorporates:
- #218518
- #218520
- #218522
- #218521
- #218523
@ghost
Copy link
Author

ghost commented Feb 26, 2023

@ofborg build pkgsCross.aarch64-multiplatform.baresip

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Feb 26, 2023
@ofborg ofborg bot requested review from elohmeier and 7c6f434c February 26, 2023 23:43
@ghost
Copy link
Author

ghost commented Feb 27, 2023

@ofborg build pkgsCross.aarch64-multiplatform.baresip

@ghost ghost marked this pull request as ready for review March 16, 2023 02:32
@ghost
Copy link
Author

ghost commented Mar 16, 2023

@ofborg build baresip

@ghost ghost merged commit b405738 into NixOS:master Mar 21, 2023
@ghost ghost deleted the pr/baresip/cross branch March 21, 2023 02:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: baresip, migrate to cmake
1 participant