Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "llvmPackages_15: update licenses" #217906

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

alyssais
Copy link
Member

This reverts commit 386aba3.

As I understand it from reading
https://llvm.org/docs/DeveloperPolicy.html#copyright-license-and-patents, the structure of LLVM licensing is as follows:

  • They're in the process of relicensing to Apache-2.0 WITH LLVM-exception, but they haven't got permission to relicense all the code yet. This means that some of the code can be used under the new license, but not all of it, and it's difficult to know which is which. This license is therefore probably not useful yet, until the relicensing effort is commit.

  • While the relicensing effort is ongoing, code being contributed to LLVM has to have permission to be used under the old and new licensing schemes. Since the new licensing scheme can't be used for all code yet, it only makes sense to use LLVM's code under the old licensing scheme at the moment.

  • The old licensing scheme is that code for the LLVM components we care about is all available under the NCSA license, and some components are optionally available under a different license, usually the MIT license, instead.

So I think we should go back to just listing NCSA, or NCSA/MIT, and forget about the new license until it actually becomes useful, i.e. LLVM's relicensing effort is complete.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This reverts commit 386aba3.

As I understand it from reading
<https://llvm.org/docs/DeveloperPolicy.html#copyright-license-and-patents>,
the structure of LLVM licensing is as follows:

 - They're in the process of relicensing to Apache-2.0 WITH LLVM-exception,
   but they haven't got permission to relicense all the code yet.
   This means that some of the code can be used under the new license,
   but not all of it, and it's difficult to know which is which.  This
   license is therefore probably not useful yet, until the relicensing
   effort is commit.

 - While the relicensing effort is ongoing, code being contributed to
   LLVM has to have permission to be used under the old and new
   licensing schemes.  Since the new licensing scheme can't be used
   for all code yet, it only makes sense to use LLVM's code under the
   old licensing scheme at the moment.

 - The old licensing scheme is that code for the LLVM components we
   care about is all available under the NCSA license, and some
   components are optionally available under a different license,
   usually the MIT license, instead.

So I think we should go back to just listing NCSA, or NCSA/MIT, and
forget about the new license until it actually becomes useful,
i.e. LLVM's relicensing effort is complete.
Copy link
Contributor

@rrbutani rrbutani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this; I'd missed that new code is still licensed under NCSA (in addition to asl20 with the exceptions). Only listing ncsa for now does seem cleaner.

@alyssais alyssais merged commit f9afd57 into NixOS:master Feb 24, 2023
@alyssais alyssais deleted the llvm-licenses branch February 24, 2023 00:06
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants