Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-support/vm/deb/deb-closure: quote generated urls #217256

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Feb 20, 2023

Description of changes

otherwise, eval fails when the experimental no-url-literals feature is activated

unquoted urls are discouraged after NixOS/rfcs#45

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

otherwise, eval fails when the experimental no-url-literals feature is activated

unquoted urls are discouraged after NixOS/rfcs#45
@Mic92 Mic92 merged commit d69bb82 into NixOS:master Feb 20, 2023
@ajs124 ajs124 deleted the deb-closure-quote-urls branch February 20, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants