Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: expose --disable-bootstrap as disableBootstrap #216136

Merged
merged 1 commit into from Feb 18, 2023
Merged

gcc: expose --disable-bootstrap as disableBootstrap #216136

merged 1 commit into from Feb 18, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2023

Description of changes

This PR exposes GCC's --disable-bootstrap flag as a (non-inverted) parameter enableBootstrap.

Eval is unchanged.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from matthewbauer as a code owner February 13, 2023 09:28
@ghost ghost mentioned this pull request Feb 13, 2023
Merged
4 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 13, 2023
@ghost ghost requested review from trofi and removed request for matthewbauer February 15, 2023 06:34
trofi
trofi approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also worth fixing commit and PR description.

@ghost ghost changed the title gcc: expose --disable-bootstrap as !enableBootstrap gcc: expose --disable-bootstrap as disableBootstrap Feb 16, 2023
@trofi trofi merged commit 2ea3482 into NixOS:staging Feb 18, 2023
@ghost ghost deleted the pr/gcc/enableBootstrap branch February 18, 2023 16:46
@SuperSandro2000
Copy link
Member

I just wanted to say that this is a really nice split out change to make the initial PR easier to review.

@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @trofi