setup-hooks/reproducible-builds.sh: NIX_OUTPATH_USED_AS_RANDOM_SEED #216016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reproducibility, nixpkgs sets `-frandom-seed` to the first 10 characters of the outpath of the derivation being built. This PR allows to manually select from which outpath the 10-character prefix is taken, by setting `NIX_OUTPATH_USED_AS_RANDOM_SEED` as a derivation attribute (or directly as an environment variable). For an example use of this functionality, see: #209870
ghost
requested a review
from 
ghost
mentioned this pull request
4 tasks
trofi
approved these changes
Feb 18, 2023
|
This was accidentally merged into master? |
|
Gah, you are right! Thank you for a prompt revert! |
|
Re-targeted against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
For reproducibility, nixpkgs sets
-frandom-seedto the first 10 characters of the outpath of the derivation being built.This PR allows to manually select from which outpath the 10-character prefix is taken, by setting
NIX_OUTPATH_USED_AS_RANDOM_SEEDas a derivation attribute (or directly as an environment variable).For an example use of this functionality, see #209870
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)