Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310: 3.10.9 -> 3.10.10; python311: 3.11.1 -> 3.11.2 #215401

Merged
merged 8 commits into from
Feb 13, 2023
Merged

python310: 3.10.9 -> 3.10.10; python311: 3.11.1 -> 3.11.2 #215401

merged 8 commits into from
Feb 13, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Feb 8, 2023 •
edited
Loading

Description of changes

https://docs.python.org/release/3.11.2/whatsnew/changelog.html
https://docs.python.org/release/3.10.10/whatsnew/changelog.htm

Based on master for testing purpose, will rebase against staging once testing is complete.l

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt requested a review from FRidh February 9, 2023 00:33
@mweinelt
Copy link
Member Author

mweinelt commented Feb 9, 2023

@ofborg build python310.tests
@ofborg build python311.tests

@mweinelt mweinelt changed the base branch from master to staging February 9, 2023 02:51
@mweinelt
Copy link
Member Author

mweinelt commented Feb 9, 2023

Welp, building it on master went nowhere, due to libuv test flakiness, that was fixed in #211896, which is currently on staging-next.

@mweinelt mweinelt marked this pull request as ready for review February 9, 2023 02:53
@mweinelt
Copy link
Member Author

mweinelt commented Feb 9, 2023 •
edited
Loading

x86_64-linux
  • python310.tests
  • python311.tests
aarch64-linux
  • python310.tests
  • python311.tests
aarch64-darwin
  • python310.tests
  • python311.tests
x86_64-darwin
  • python310.tests
  • python311.tests

@mweinelt
python3.tests.condaExamplePackage: Exclude on non-linux
20c723d 
Allow python3.tests to eval on other platforms than linux, by excluding
conda tests when not on linux, because they include alsa-lib, which is
linux-only.
@mweinelt
python310Packages.asgiref: Fix tests on darwin
a48dcc5
@mweinelt
python310Packages.ephemeral-port-reserve: Fix tests on darwin
f75329f
@mweinelt
python3.tests.nixenv-virtualenv: Fix on darwin
d704ee7 
The virtualenv mode is trying to be smart and checks whether it can
write to $out, which for some reason fails on darwin.

> virtualenv: error: argument dest: the destination . is not write-able at /nix/store

But what does work is creating it in the pwd and moving it to $out,
because mv just does what it is told.
@mweinelt
Copy link
Member Author

x86_64-darwin failing in darwin.apple_sdk_11_0.IOKit

IOKit-x86_64-darwin> source root is .
IOKit-x86_64-darwin> setting SOURCE_DATE_EPOCH to timestamp 1633495632 of file ./IOUSBFamily-IOUSBFamily-630.4.5/USBProberV2/version.plist
IOKit-x86_64-darwin> patching sources
IOKit-x86_64-darwin> configuring
IOKit-x86_64-darwin> no configure script, doing nothing
IOKit-x86_64-darwin> building
IOKit-x86_64-darwin> no Makefile or custom buildPhase, doing nothing
IOKit-x86_64-darwin> installing
IOKit-x86_64-darwin> /nix/store/0lk5sy3ik47jz6wxyf1lbbmgkhk621g6-IOKit-/Library/Frameworks/IOKit.framework/Headers /private/tmp/nix-build-IOKit-.drv-0
IOKit-x86_64-darwin> /private/tmp/nix-build-IOKit-.drv-0
IOKit-x86_64-darwin> cp: cannot stat 'IOUSBFamily-630.4.5/IOUSBFamily/Headers/IOUSBLib.h': No such file or directory

@winterqt winterqt mentioned this pull request Feb 12, 2023
Merged
13 tasks
@mweinelt mweinelt merged commit d87b0e2 into NixOS:staging Feb 13, 2023
@mweinelt mweinelt deleted the python-3.10.10-3.11.2 branch February 13, 2023 13:26
@alyssais
Copy link
Member

@mweinelt this has broken eval

error: Function called without required argument "sha256" at /home/qyliss/src/nixpkgs/pkgs/development/interpreters/python/cpython/2.7/default.nix:27

@alyssais
Copy link
Member

#216189

@mweinelt mweinelt mentioned this pull request Apr 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweinelt @alyssais