Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headscale: 0.18.0 -> 0.19.0 #213646

Merged
merged 1 commit into from
Jan 31, 2023
Merged

headscale: 0.18.0 -> 0.19.0 #213646

merged 1 commit into from
Jan 31, 2023

Conversation

pzeinlinger
Copy link
Contributor

Description of changes

https://github.com/juanfont/headscale/releases/tag/v0.19.0

BREAKING

  • Rename Namespace to User #1144
    • BACKUP your database before upgrading
  • Command line flags previously taking --namespace or -n will now require --user or -u
Things done
  • Built on platform(s)
    • [X ] x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NickCao
Copy link
Member

NickCao commented Jan 31, 2023 •
edited
Loading

BACKUP your database before upgrading

Is this release note worthy?

@06kellyjac
Copy link
Member

06kellyjac commented Jan 31, 2023 •
edited
Loading

Merge branch 'NixOS:master' into master

can this just be the change commit. you can rebase this branch on origin/master rather than merging master into this branch

Edit: and thanks for contributing 🚀

@kradalby
Copy link
Member

Is this release note worthy?

Headscale always recommends people to backup their database before an upgrade, this is in principle an extra reminder.

06kellyjac
06kellyjac approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the commit history @pzeinlinger

LGTM 👍

@pzeinlinger
Copy link
Contributor Author

Merge branch 'NixOS:master' into master

can this just be the change commit. you can rebase this branch on origin/master rather than merging master into this branch

Edit: and thanks for contributing rocket

@06kellyjac done 👍

NKJe
NKJe approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@NKJe NKJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ♥️

@NickCao
Copy link
Member

NickCao commented Jan 31, 2023

@ofborg build headscale

@NickCao NickCao merged commit d1246b8 into NixOS:master Jan 31, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@06kellyjac 06kellyjac 06kellyjac approved these changes

@NKJe NKJe NKJe approved these changes

@kradalby kradalby kradalby approved these changes

@Misterio77 Misterio77 Awaiting requested review from Misterio77

@ghuntley ghuntley Awaiting requested review from ghuntley

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pzeinlinger @NickCao @06kellyjac @kradalby @NKJe @Janik-Haag