Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_15: add attributes #213497

Merged
merged 1 commit into from
Jan 30, 2023
Merged

llvmPackages_15: add attributes #213497

merged 1 commit into from
Jan 30, 2023

Conversation

Et7f3
Copy link
Contributor

@Et7f3 Et7f3 commented Jan 30, 2023 •
edited
Loading

Description of changes

I diffed the two llvm 15 PR and I picked one thing that lack in master. I think I haven't missed anything important their.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Et7f3 Et7f3 marked this pull request as ready for review January 30, 2023 03:33
@Et7f3 Et7f3 mentioned this pull request Jan 30, 2023
Closed
48 tasks
@wegank wegank merged commit 6b6fda0 into NixOS:master Jan 30, 2023
@rrbutani
Copy link
Contributor

rrbutani commented Jan 30, 2023 •
edited
Loading

Thanks, good catch!

@Et7f3 Et7f3 deleted the add_llvm15_attribute branch January 30, 2023 18:28
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Et7f3 @rrbutani @wegank