Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_{12,13,14}: Disable tests on RISC-V #211728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhaofengli
Copy link
Member

@zhaofengli zhaofengli commented Jan 20, 2023

Description of changes

Same rationale as #125132 😢 Not required on LLVM 15 since the test suite runs fine.

Ref: #101651

Things done
  • Built on platform(s)
    • riscv64-linux
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Same rationale as #125132 😢

Could we add a very short comment with that?

@zhaofengli zhaofengli changed the title llvmPackages_14: Disable tests on RISC-V llvmPackages_{12,13,14}: Disable tests on RISC-V Jan 23, 2023
@rrbutani rrbutani mentioned this pull request Jan 25, 2023
92 tasks
@zhaofengli zhaofengli marked this pull request as draft February 1, 2023 02:54
@zhaofengli
Copy link
Member Author

Marking as draft until I test out LLVM 15. Now LLD finally supports RISC-V linker relaxation so we may want to switch to that by default.

@zhaofengli
Copy link
Member Author

With LLVM 15, all tests passed just fine on RISC-V 🎉 I'll build test more packages and open a separate PR to change the default LLVM version.

running tests
check flags: -j4 check-all
[1/2] Preparing lit tests
[1/2] Running all regression tests
-- Testing: 43965 tests, 4 workers --

Testing Time: 7874.56s
  Skipped          :     8
  Unsupported      :  1973
  Passed           : 48212
  Expectedly Failed:   172
checkPhase completed in 2 hours 12 minutes 0 seconds

@zhaofengli zhaofengli marked this pull request as ready for review February 2, 2023 01:04
@rrbutani rrbutani mentioned this pull request Mar 6, 2023
12 tasks
@SeTSeR
Copy link
Contributor

SeTSeR commented May 12, 2023

Which board was LLVM15 tested on? I tried to build LLVM on my visionfive2, and there is still one test failing (I don’t have a full build log at hand right now, but I’m pretty sure that was PerfEventTest). So maybe disable tests for LLVM15 too?

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants