-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_{12,13,14}: Disable tests on RISC-V #211728
base: master
Are you sure you want to change the base?
Conversation
Could we add a very short comment with that? |
41b1933
to
2d01a63
Compare
Same rationale as in 125132.
2d01a63
to
6cb0ad5
Compare
Marking as draft until I test out LLVM 15. Now LLD finally supports RISC-V linker relaxation so we may want to switch to that by default. |
With LLVM 15, all tests passed just fine on RISC-V 🎉 I'll build test more packages and open a separate PR to change the default LLVM version.
|
Which board was LLVM15 tested on? I tried to build LLVM on my visionfive2, and there is still one test failing (I don’t have a full build log at hand right now, but I’m pretty sure that was |
Description of changes
Same rationale as #125132 😢 Not required on LLVM 15 since the test suite runs fine.
Ref: #101651
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes