-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtool: drop unused auto* dependencies #210118
Conversation
Autoreconf was initially added in e44dd84 ("libtool2: macOS 11 support") for configure patches. The patches were removed since 2.4.7 release. Let's drop these dependencies to make boostrap tree leaner. The diff of bootstrap tree before and after the change: $ nix-store --query --graph $(nix-instantiate -A stdenv) | fgrep ' -> ' | awk '{print $3}' | sort -u | sed 's/"[0-9a-z]\{32\}-/"/g' | sort > before $ nix-store --query --graph $(nix-instantiate -A stdenv) | fgrep ' -> ' | awk '{print $3}' | sort -u | sed 's/"[0-9a-z]\{32\}-/"/g' | sort > after $ diff -U0 before after --- before +++ after @@ -64,2 +63,0 @@ -"help2man-1.49.2.drv" -"help2man-1.49.2.drv" @@ -77 +74,0 @@ -"libxcrypt-4.4.33.drv" @@ -88,4 +84,0 @@ -"perl-5.36.0.drv" -"perl-5.36.0.drv" -"perl5.36.0-gettext-1.07.drv" -"perl5.36.0-gettext-1.07.drv" This removes 2 of 3 builds of `perl` and `help2man` dependencies. Co-authored-by: Adam Joseph <54836058+amjoseph-nixpkgs@users.noreply.github.com>
596f56b
to
6becbd3
Compare
This seem to break build on aarch64 for me.
@amjoseph-nixpkgs is that something you are tackling as part of gcc11 for aarch64? |
which build is that from? libtool builds for me on e09153d on aarch64-linux |
The latest nixos-unstable-small (c85d086). I should add that it is not a native build but cross build. |
this PR isn't even in master yet https://nixpk.gs/pr-tracker.html?pr=210118 so your issue is from some other commit |
Oh.. sorry. You are right. The build process still includes help2man in my version. I jumped at this because I saw it being removed here. I have to investigate more than to know why it reports that it is not available in my case. |
Do you apply local patches to |
That would be my idea as well, but no. I am not applying any patches. I tried to bisect the commit that might have broke it, but I ended up with a working build after bisect even on nixos-unstable-small. There is something smelly in libtool build. |
Autoreconf was initially added in e44dd84 ("libtool2: macOS 11 support") for configure patches. The patches were removed since 2.4.7 release. Let's drop these dependencies to make boostrap tree leaner.
The diff of bootstrap tree before and after the change:
This removes 2 of 3 builds of
perl
andhelp2man
dependencies.Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes