gcc: pass hostEqualsTarget to builder #210097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently gcc's builder.sh (ab)uses `targetConfig` to determine if host==target. For external bootstrap we may need to pass a `targetConfig` even for native builds. Therefore this commit passes a separate flag to indicate if host==target.
ghost
requested a review
from 
ghost
mentioned this pull request
|
This turns out to be unnecessary, and in fact a bad idea. We should be sending more builds through the cross-codepath rather than the native-codepath. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently gcc's builder.sh (ab)uses
targetConfigto determine if host==target. For external bootstrap we may need to pass atargetConfigeven for native builds. Therefore this commit passes a separate flag to indicate if host==target.Things done