-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qemacs: fix cross-compilation #209417
qemacs: fix cross-compilation #209417
Conversation
Also adds enableX11 parameter.
Build on darwin seems broken, is it related? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you for your work! I didn't test cross compilation, all the changes look very solid.
I cannot comment on the darwin situation.
I'm afraid I do not have access to any darwin machines. |
you can request access to https://github.com/winterqt/darwin-build-box if you want |
makeFlags = [ | ||
# is actually used as BUILD_CC | ||
"HOST_CC=${buildPackages.stdenv.cc}/bin/cc" | ||
"CC=${stdenv.cc.targetPrefix}cc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upstream assumes gcc
it's a pre-existing issue, fixed the gcc error but there's still
|
Closed by #209418 |
Description of changes
This fixes cross-compilation for qemacs. It also adds enableX11 parameter.
Things done
./result/bin/
)