Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qemacs: fix cross-compilation #209417

Closed
wants to merge 3 commits into from
Closed

qemacs: fix cross-compilation #209417

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2023

Description of changes

This fixes cross-compilation for qemacs. It also adds enableX11 parameter.

Things done
  • Built on platform(s)
    • x86_64-linux
    • powerpc64le-linux
    • aarch64-linux
    • mips64el-linux (cross from powerpc64le-linux)
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Also adds enableX11 parameter.
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 7, 2023
@ofborg ofborg bot requested a review from iblech January 7, 2023 05:04
@Mindavi
Copy link
Contributor

Mindavi commented Jan 9, 2023

Build on darwin seems broken, is it related?

Copy link
Contributor

@iblech iblech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for your work! I didn't test cross compilation, all the changes look very solid.

I cannot comment on the darwin situation.

@ghost
Copy link
Author

ghost commented Jan 13, 2023

Build on darwin seems broken, is it related?

I'm afraid I do not have access to any darwin machines.

@Artturin
Copy link
Member

Build on darwin seems broken, is it related?

I'm afraid I do not have access to any darwin machines.

you can request access to https://github.com/winterqt/darwin-build-box if you want

makeFlags = [
# is actually used as BUILD_CC
"HOST_CC=${buildPackages.stdenv.cc}/bin/cc"
"CC=${stdenv.cc.targetPrefix}cc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upstream assumes gcc

@Artturin
Copy link
Member

Build on darwin seems broken, is it related?

it's a pre-existing issue, fixed the gcc error but there's still

qe.c:32:31: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
int (*__initcall_first)(void) __init_call = NULL;
                              ^
./qe.h:581:57: note: expanded from macro '__init_call'
#define __init_call     __attribute__ ((unused,__section__ (".initcall.init")))
                                                            ^
qe.c:33:32: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma
void (*__exitcall_first)(void) __exit_call = NULL;
                               ^
./qe.h:582:57: note: expanded from macro '__exit_call'
#define __exit_call     __attribute__ ((unused,__section__ (".exitcall.exit")))

@ofborg ofborg bot requested a review from iblech January 19, 2023 16:10
@Mindavi
Copy link
Contributor

Mindavi commented Feb 22, 2023

Closed by #209418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants