Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: fix on aarch64-linux by using GCC 11 and passing -lgcc #209113

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

winterqt
Copy link
Member

@winterqt winterqt commented Jan 4, 2023

Description of changes

This change switches to using GCC 11 by default on aarch64-linux, as well as passing -lgcc to the linker, per #201485.

See #201254 and #208412 for wider context on the issue.

I'm opening this just so we have something to fall back on for the short-term in case #209063 has to be held back for whatever reason. As such, this is a draft, but just to prevent merging; I appreciate any and all reviews.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux, nix-build -A fd
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This change switches to using GCC 11 by default on aarch64-linux, as well as passing `-lgcc` to the linker, per NixOS#201485.

See NixOS#201254 and NixOS#208412 for wider context on the issue.
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, #209063 might take a while to land (week(s)?).

The workaround looks good.

@mweinelt mweinelt marked this pull request as ready for review January 5, 2023 16:07
@mweinelt mweinelt requested review from Mic92, LnL7 and zowoq as code owners January 5, 2023 16:07
@mweinelt mweinelt merged commit 7d05447 into NixOS:staging Jan 5, 2023
@winterqt winterqt deleted the rust-aarch64-linux-fix branch January 5, 2023 17:52
@vcunat
Copy link
Member

vcunat commented Jan 6, 2023

Maybe we'll need something similar for spidermonkey? https://hydra.nixos.org/build/204263464

vcunat added a commit that referenced this pull request Jan 13, 2023
All three versions are the same in this respect.
It's the issue with old libgcc_s propagated via our glibc package; e.g.
#209113
vcunat added a commit to vcunat/nixpkgs that referenced this pull request Jan 15, 2023
It's the issue with old libgcc_s propagated via our glibc package; e.g.
NixOS#209113
@mweinelt mweinelt mentioned this pull request Feb 14, 2023
13 tasks
winterqt pushed a commit to winterqt/nixpkgs that referenced this pull request Feb 15, 2023
All three versions are the same in this respect.
It's the issue with old libgcc_s propagated via our glibc package; e.g.
NixOS#209113

(cherry picked from commit 77a214e)
winterqt pushed a commit to winterqt/nixpkgs that referenced this pull request Feb 15, 2023
It's the issue with old libgcc_s propagated via our glibc package; e.g.
NixOS#209113

(cherry picked from commit cdf0283)
winterqt added a commit to winterqt/nixpkgs that referenced this pull request Feb 15, 2023
See NixOS#209113 for context. This has to
be done manually because rpm-ostree doesn't use the Cargo setup hooks (which
automatically set this flag).
mweinelt pushed a commit that referenced this pull request Feb 15, 2023
It's the issue with old libgcc_s propagated via our glibc package; e.g.
#209113

(cherry picked from commit cdf0283)
wegank added a commit to wegank/nixpkgs that referenced this pull request Mar 1, 2023
This commit reverts NixOS#209113, since aarch64-linux now uses GCC 12 by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants