Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-cross.nix: nixCrossStatic: do not burden *-darwin builders #208856

Merged
merged 1 commit into from Jan 3, 2023
Merged

release-cross.nix: nixCrossStatic: do not burden *-darwin builders #208856

merged 1 commit into from Jan 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 3, 2023

Description of changes

PR #181151 added the nixCrossStatic jobs, which cross-compile nixStatic for (currently) mips64el and powerpc64le, so users on those platforms can use it to bootstrap their own builds of nixpkgs/nixos:

#181151

However I unintentionally caused that PR to queue this job on all Hydra builders, including the (heavily burdened) *-darwin builders:

https://hydra.nixos.org/build/203846776
https://hydra.nixos.org/build/203846780

There is no need to build these derivations with a darwin buildPlatform. Let's limit this task to only buildPlatform=*-linux.

CC: @vcunat

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

PR #181151 added the nixCrossStatic jobs, which cross-compile
nixStatic for (currently) mips64el and powerpc64le, so users on
those platforms can use it to bootstrap their own builds of
nixpkgs/nixos:

  #181151

However I unintentionally caused that PR to queue this job on *all*
Hydra builders, including the (heavily burdened) *-darwin builders:

  https://hydra.nixos.org/build/203846776
  https://hydra.nixos.org/build/203846780

There is no need to build these derivations with a darwin
buildPlatform.  Let's limit this task to only buildPlatform=*-linux.
@ghost ghost requested review from Ericson2314 and matthewbauer as code owners January 3, 2023 09:31
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: darwin Running or building packages on Darwin labels Jan 3, 2023
@ghost
Copy link
Author

ghost commented Jan 3, 2023

@vcunat if you want to manually intervene and cancel those two jobs on Hydra, go for it. They're going to bootstrap an entire cross-compilation chain, so they will be really big jobs.

Sorry about this. I should have realized this would happen when I submitted the PR.

@Artturin Artturin merged commit 45f0947 into NixOS:master Jan 3, 2023
@ghost ghost deleted the pr/nixCrossStatic/fewerjobs branch January 3, 2023 22:54
@vcunat
Copy link
Member

vcunat commented Jan 4, 2023

All of them got dropped:

in job ‘powerpc64le-nixCrossStatic.nixStatic’:
error: undefined variable 'platforms'

https://hydra.nixos.org/eval/1788729#tabs-removed

@Artturin
Copy link
Member

Artturin commented Jan 4, 2023

fix in #209041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants