nss: convert NIX_CFLAGS_COMPILE to a list #208704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Nss has a lot of dependers, so subtle whitespace changes can cause mass rebuilds, like I did here: #208698 (comment) Let's use a list instead of concatenating individual strings in order to be more robust. This will cause a lot of rebuilds, but will prevent rebuilds in the future. Sending it this cleanup to staging because of that.
ghost
marked this pull request as ready for review
|
LGTM. We could wait until the next nss (esr) release with this, which will trigger most of these same rebuilds anyway. |
ghost
marked this pull request as draft
|
See #210137 for said update |
ghost
marked this pull request as ready for review
|
This is on staging now, so IMO we can close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Nss has a lot of dependers, so subtle whitespace changes can cause mass rebuilds, like I did here:
#208698 (comment)
Let's use a list instead of concatenating individual strings in order to be more robust. This will cause a lot of rebuilds, but will prevent rebuilds in the future. Sending it this cleanup to staging because of that.
Marked as draft until #208698 merges. This includes the commits from that PR in order to avoid a merge conflict.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes