Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nss: set -DNS_PTR_LE_32=1 if isILP32 #208698

Merged
merged 2 commits into from Jan 3, 2023
Merged

nss: set -DNS_PTR_LE_32=1 if isILP32 #208698

merged 2 commits into from Jan 3, 2023

Commits on Jan 2, 2023

  1. lib/systems/inspect.nix: add isILP32 predicate 

    I've run into a few packages that need an extra flag on platforms
where `int` has more bits than `void*` does.  I know of three such
platforms:

* [aarch64ilp32], used on both Linux and also on the [Apple Watch]
* [x32], the x86 ILP32 ABI
* [mips64n32], used on [Longsoon] and Cavium Octeon routers.

This PR introduces a predicate so the package flags can be added in
a generic way.

[Apple Watch]: https://gist.github.com/woachk/943828f37c14563a607a26116435bf27#watch
[mips64n32]: https://en.wikipedia.org/wiki/MIPS_architecture#Calling_conventions
[Longsoon]: https://en.wikipedia.org/wiki/Loongson
[x32]: https://en.wikipedia.org/wiki/X32_ABI
    Adam Joseph committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    14f337a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. nss: set -DNS_PTR_LE_32=1 if isILP32 

    A comment in RNG_RandomUpdate() (drdbg.c) says to add the
-DNS_PTR_LE_32=1 flag on ILP32 platforms.

Without this PR, pkgsCross.mips64el-linux-gnuabin32.nss fails to
build.  With this PR, it succeeds.
    Adam Joseph committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    c0a40be View commit details
    Browse the repository at this point in the history