Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmdstan: add aarch64-darwin support #208132

Merged
merged 2 commits into from
Jan 10, 2023
Merged

cmdstan: add aarch64-darwin support #208132

merged 2 commits into from
Jan 10, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Dec 28, 2022 •
edited
Loading

Description of changes

Following #203381.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member Author

wegank commented Dec 28, 2022

@ofborg build cmdstan cmdstan.passthru.tests

@wegank wegank changed the title cmdstan: 2.30.1 -> 2.31.0 cmdstan: add aarch64-darwin support Dec 29, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1651

@wegank wegank marked this pull request as draft January 3, 2023 23:15
@wegank
Copy link
Member Author

wegank commented Jan 3, 2023 •
edited
Loading

The build mysteriously fails on my aarch64-darwin machine...

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 4, 2023
@wegank wegank marked this pull request as ready for review January 4, 2023 00:27
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1677

@SuperSandro2000 SuperSandro2000 merged commit b5bd459 into NixOS:master Jan 10, 2023
@wegank wegank deleted the cmdstan-aarch64-linux branch January 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wegank @nixos-discourse @SuperSandro2000