Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch-install-scripts: avoid using setuid wrappers #206658

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

SamLukeYes
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@SamLukeYes SamLukeYes requested a review from abathur December 18, 2022 03:32
@SamLukeYes
Copy link
Member Author

To use unshare mode before this PR is merged, expose the real mount/umount to the environment, e.g. nix-shell -p util-linux.

@SamLukeYes SamLukeYes requested a review from PedroHLC December 18, 2022 03:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 18, 2022
SamLukeYes added a commit to SamLukeYes/nixos that referenced this pull request Dec 18, 2022
@abathur
Copy link
Member

abathur commented Dec 18, 2022

Commented in abathur/resholve#29 about a better workaround that should spare the substitute/keep/fake.

@SamLukeYes
Copy link
Member Author

Commented in abathur/resholve#29 about a better workaround that should spare the substitute/keep/fake.

Thanks! It looks much better now. :)

@bobby285271 bobby285271 merged commit 6686dee into NixOS:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unshare mode doesn't work on NixOS
3 participants