insync: 3.3.5.40925 -> 3.8.5.50499 #205954

hellwolf · 2022-12-13T19:00:49Z

Description of changes

The insync-v3 package is currently broken in both master and 22.11.

Resolution

Deleting insync-v3 from top-level, superseded by insync.
Using buildFHSEnv to simplify packaging process.
Drop backport attempt for 22.11 for this package going forward.

Related Issues

[BLOCKED] Python pyside2/shiboken2: fix build issue for older python versions using libxcrypt #207829 - Because it has dependencies on python 3.7 packages pyside2 and shiboken2, it also depends on pull request.
[RELATED] closes insync-v3 does not build because it cannot access a <source> deb #186805
[RELATED] closes insync-v3 server doesn't seem to start #139728

Things done

hellwolf · 2022-12-25T10:51:35Z

Current the binary crashes, will find the root cause of it.

hellwolf · 2022-12-26T02:25:47Z

Update: I managed to make it work, but I still need to make some extra fixes to make shiboken2 and pyside2 built for python 2.7, I am merging upstream code then pushing to this pull request soon.

hellwolf · 2022-12-26T13:26:31Z

Pulled out the python packages change to #207829

benley · 2022-12-26T18:19:43Z

When you are eventually ready to merge this, would you like to take over maintainership of the derivation in nixpkgs? I'm going to remove myself from the meta.maintainers line since I haven't been using insync for a few years now.

hellwolf · 2022-12-26T20:30:11Z

When you are eventually ready to merge this, would you like to take over maintainership of the derivation in nixpkgs? I'm going to remove myself from the meta.maintainers line since I haven't been using insync for a few years now.

Happy to do so, since I am still using it as part of the workflow. I don't know how to add myself to maintainers list yet, I will look into it.

hellwolf · 2022-12-27T12:02:11Z

For some reason, the system tray icon is not visible. I am using gnomeExtensions.appindicator.

It seems a chronic bug in upstream insync, I will consider it a known bug and mark this PR ready for now.

hellwolf · 2022-12-27T12:05:04Z

~~@benley do you want me to update the maintainer-list.nix and change the meta.maintainers in the same pull request.~~

Never mind, I just noticed that you already removed yourself from upstream.

Ready to merge!

benley · 2022-12-27T18:35:09Z

doing some testing now!

hellwolf · 2023-05-08T20:16:21Z

Now things segfault using or not using steam-run:

$ ./result/lib/insync/insync start --no-daemon
Segmentation fault (core dumped)
$ ./result/bin/insync start --no-daemon
$ # nothing

to be continued...

hellwolf · 2023-05-08T21:38:17Z

Good news folks! It works now! Without using full steam-run, instead with a very minimum FHS! Please give it a try!

Although the system tray icon still not working:

$ result/bin/insync-3.8.5.50499 start --no-daemon 
QApplication: invalid style override passed, ignoring it.
    Available styles: Windows, Fusion
QSystemTrayIcon::setVisible: No Icon set

I will give a few more debugging of this before call it known bug and consider we are good to go for this package again!

hellwolf · 2023-05-08T21:45:46Z

@ofborg build insync

hellwolf · 2023-05-09T09:06:35Z

Everyone this is ready now!!

Removed insync-v3 from top-level, with only insync superseding it.
insync: 3.3.5.40925 -> 3.8.5.50499
- Simplified packaging process:
  - Use as much vendor provided binaries as possible.
  - Only replace glibc with system provided ones (2.36+ required, hence
    nixos 22.11 is out).
  - Use buildFHSEnv to create FHS environment to run insync in.
- Known bug(s):
  1. Currently the system try icon does not render correctly.
  2. libqtvirtualkeyboardplugin does not have necessary Qt library shipped from vendor.

SuperSandro2000 · 2023-05-09T11:24:37Z

Please don't use steam-run as it is giant and has a proprietary dependencies on steam, use a plain fhs instead and add the libraries that are required to it.

SuperSandro2000 · 2023-05-09T11:26:05Z

pkgs/applications/networking/insync/default.nix

+in buildFHSEnv { # ref: pkgs/build-support/build-fhsenv-bubblewrap/default.nix
+  name = "${pname}-${version}";
+  inherit meta;
+
+  # for including insync's xdg data dirs
+  extraOutputsToInstall = [ "share" ];
+
+  targetPkgs = pkgs: [
+    insync-pkg
+  ];
+
+  multiPkgs = pkgs: with pkgs; [
+    # apparently only package needed for the FHS :)
+    libudev0-shim
+  ];
+
+  runScript = writeShellScript "insync-wrapper.sh" ''
+    export QT_STYLE_OVERRIDE=Fusion
+    exec "${insync-pkg.outPath}/lib/insync/insync" "$@"
+  '';
+  # "insync start" command starts a daemon.
+  dieWithParent = false;


Suggested change

in buildFHSEnv { # ref: pkgs/build-support/build-fhsenv-bubblewrap/default.nix

name = "${pname}-${version}";

inherit meta;

# for including insync's xdg data dirs

extraOutputsToInstall = [ "share" ];

targetPkgs = pkgs: [

insync-pkg

];

multiPkgs = pkgs: with pkgs; [

# apparently only package needed for the FHS :)

libudev0-shim

];

runScript = writeShellScript "insync-wrapper.sh" ''

export QT_STYLE_OVERRIDE=Fusion

exec "${insync-pkg.outPath}/lib/insync/insync" "$@"

'';

# "insync start" command starts a daemon.

dieWithParent = false;

in buildFHSEnv {

name = "${pname}-${version}";

inherit pname version;

# for including insync's xdg data dirs

extraOutputsToInstall = [ "share" ];

targetPkgs = pkgs: [

insync-pkg

];

multiPkgs = pkgs: with pkgs; [

libudev0-shim

];

runScript = writeShellScript "insync-wrapper.sh" ''

export QT_STYLE_OVERRIDE=Fusion

exec "${insync-pkg.outPath}/lib/insync/insync" "$@"

'';

# "insync start" command starts a daemon.

dieWithParent = false;

inherit meta;

Do we really must enforce the qt style?
Do we need to use multiPkgs aka 32 and 64 bit?

Do we really must enforce the qt style?

Not necessarily, it was added to suppress one warning from Qt output.

Do we need to use multiPkgs aka 32 and 64 bit?

No, only 64bit binaries are shipped from the vendor.

pkgs/applications/networking/insync/default.nix

SuperSandro2000 · 2023-05-09T11:27:03Z

pkgs/applications/networking/insync/default.nix

+    preBuild = ''
+      addAutoPatchelfSearchPath $out/lib/insync/
+    '';


Do we need this even when using fhs?

I will give it a try, probably not anymore.

yep, no longer needed, eliminated.

hellwolf · 2023-05-09T12:43:39Z

Please don't use steam-run as it is giant and has a proprietary dependencies on steam, use a plain fhs instead and add the libraries that are required to it.

Yep, using buildFHSEnv now after other recommending, works like a charm.

hellwolf · 2023-05-10T16:22:28Z

Anything more I can do to help to get this merged?

benley

Let's give @SuperSandro2000 a chance to chime in once more before merging but this looks pretty solid to me!

nixos-discourse · 2023-05-11T16:15:28Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2199

SuperSandro2000 · 2023-05-11T21:54:47Z

pkgs/top-level/all-packages.nix

@@ -33912,8 +33912,6 @@ with pkgs;

  insync = callPackage ../applications/networking/insync { };

-  insync-v3 = libsForQt5.callPackage ../applications/networking/insync/v3.nix { };


we should add an alias for this

Is it still good to keep this -v3 alias though? maybe time to deprecate it if there is no intention to keep maintaining multiple versions going forward?

see https://github.com/NixOS/nixpkgs/blob/master/doc/contributing/submitting-changes.chapter.md#:~:text=Add%20an%20alias%20for%20the%20package%20name%20in%20pkgs/top%2Dlevel/aliases.nix and https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L3-L18

Thank you for pointing this out, I amended the commits!

insync-v3 has been merged into the insync package; use insync instead.

- Simplified packaging process: - Use as much vendor provided binaries as possible. - Only replace glibc with system provided ones (2.36+ required, hence nixos 22.11 is out). - Use buildFHSEnv to create FHS environment to run insync in. Known bug(s): 1) Currently the system try icon does not render correctly. 2) libqtvirtualkeyboardplugin does not have necessary Qt library shipped from vendor.

hellwolf · 2023-05-14T12:33:05Z

Good day everyone! I have fixed the alias issue as suggested by @SuperSandro2000 , can this still make to the 2023-05-15 timeline?

SuperSandro2000 · 2023-05-15T13:38:48Z

That timeline is not relevant for unimportant leave packages.

ofborg bot requested a review from benley December 13, 2022 19:42

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 13, 2022

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 labels Dec 26, 2022

github-actions bot added the 6.topic: python label Dec 26, 2022

This was referenced Dec 26, 2022

insync-v3 server doesn't seem to start #139728

Closed

insync-v3 does not build because it cannot access a <source> deb #186805

Closed

hellwolf force-pushed the fix-insync-v3 branch from a17610e to b3a8b06 Compare December 26, 2022 13:04

hellwolf changed the title ~~insync-v3 fix WIP~~ insync-v3: fix build Dec 26, 2022

hellwolf force-pushed the fix-insync-v3 branch from c053dfd to 67a31ba Compare December 26, 2022 20:27

github-actions bot removed the 6.topic: python label Dec 26, 2022

hellwolf marked this pull request as ready for review December 27, 2022 12:02

hellwolf force-pushed the fix-insync-v3 branch from 67a31ba to 7c5a09b Compare December 27, 2022 12:16

ofborg bot added the 11.by: package-maintainer label Dec 27, 2022

hellwolf force-pushed the fix-insync-v3 branch 3 times, most recently from bab484e to a948ae9 Compare December 27, 2022 14:56

hellwolf mentioned this pull request Dec 27, 2022

maintainer-list: add hellwolf #207985

Closed

13 tasks

ofborg bot added 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 labels May 8, 2023

hellwolf force-pushed the fix-insync-v3 branch 2 times, most recently from 206998a to 4c5f1b0 Compare May 9, 2023 09:03

hellwolf marked this pull request as ready for review May 9, 2023 09:03

hellwolf force-pushed the fix-insync-v3 branch from 4c5f1b0 to 8d3fc59 Compare May 9, 2023 09:04

hellwolf changed the title ~~insync-v3: update to 3.8.5.50499~~ insync: 3.3.5.40925 -> 3.8.5.50499 May 9, 2023

hellwolf requested a review from SuperSandro2000 May 9, 2023 09:14

SuperSandro2000 reviewed May 9, 2023

View reviewed changes

hellwolf force-pushed the fix-insync-v3 branch from 9f692d7 to cb5ad34 Compare May 9, 2023 12:53

hellwolf requested a review from SuperSandro2000 May 9, 2023 12:54

hellwolf force-pushed the fix-insync-v3 branch from cb5ad34 to 3dec673 Compare May 10, 2023 18:57

benley approved these changes May 10, 2023

View reviewed changes

SuperSandro2000 reviewed May 11, 2023

View reviewed changes

hellwolf added 3 commits May 13, 2023 22:11

insync: superceded by insync-v3

9b9eaf0

insync-v3: remove

7a6a78c

insync-v3 has been merged into the insync package; use insync instead.

hellwolf force-pushed the fix-insync-v3 branch from 3dec673 to 11b9679 Compare May 13, 2023 19:11

SuperSandro2000 merged commit 1e8edc1 into NixOS:master May 15, 2023

hellwolf deleted the fix-insync-v3 branch May 15, 2023 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

insync: 3.3.5.40925 -> 3.8.5.50499 #205954

insync: 3.3.5.40925 -> 3.8.5.50499 #205954

hellwolf commented Dec 13, 2022 •

edited

Loading

hellwolf commented Dec 25, 2022

hellwolf commented Dec 26, 2022 •

edited

Loading

hellwolf commented Dec 26, 2022 •

edited

Loading

benley commented Dec 26, 2022

hellwolf commented Dec 26, 2022

hellwolf commented Dec 27, 2022

hellwolf commented Dec 27, 2022 •

edited

Loading

benley commented Dec 27, 2022

hellwolf commented May 8, 2023 •

edited

Loading

hellwolf commented May 8, 2023

hellwolf commented May 8, 2023

hellwolf commented May 9, 2023

SuperSandro2000 commented May 9, 2023

SuperSandro2000 May 9, 2023

hellwolf May 9, 2023

SuperSandro2000 May 9, 2023

hellwolf May 9, 2023

hellwolf May 9, 2023

hellwolf commented May 9, 2023

hellwolf commented May 10, 2023

benley left a comment

nixos-discourse commented May 11, 2023

SuperSandro2000 May 11, 2023

hellwolf May 11, 2023

SuperSandro2000 May 12, 2023

hellwolf May 13, 2023

hellwolf commented May 14, 2023

SuperSandro2000 commented May 15, 2023

		@@ -33912,8 +33912,6 @@ with pkgs;

		insync = callPackage ../applications/networking/insync { };

		insync-v3 = libsForQt5.callPackage ../applications/networking/insync/v3.nix { };

insync: 3.3.5.40925 -> 3.8.5.50499 #205954

insync: 3.3.5.40925 -> 3.8.5.50499 #205954

Conversation

hellwolf commented Dec 13, 2022 • edited Loading

Description of changes

Resolution

Related Issues

Things done

hellwolf commented Dec 25, 2022

hellwolf commented Dec 26, 2022 • edited Loading

hellwolf commented Dec 26, 2022 • edited Loading

benley commented Dec 26, 2022

hellwolf commented Dec 26, 2022

hellwolf commented Dec 27, 2022

hellwolf commented Dec 27, 2022 • edited Loading

benley commented Dec 27, 2022

hellwolf commented May 8, 2023 • edited Loading

hellwolf commented May 8, 2023

hellwolf commented May 8, 2023

hellwolf commented May 9, 2023

SuperSandro2000 commented May 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellwolf commented May 9, 2023

hellwolf commented May 10, 2023

benley left a comment

Choose a reason for hiding this comment

nixos-discourse commented May 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hellwolf commented May 14, 2023

SuperSandro2000 commented May 15, 2023

hellwolf commented Dec 13, 2022 •

edited

Loading

hellwolf commented Dec 26, 2022 •

edited

Loading

hellwolf commented Dec 26, 2022 •

edited

Loading

hellwolf commented Dec 27, 2022 •

edited

Loading

hellwolf commented May 8, 2023 •

edited

Loading