Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.modeled: fix build #203260

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

python3Packages.modeled: fix build #203260

wants to merge 1 commit into from

Conversation

applePrincess
Copy link
Contributor

Description of changes

ZHF: #199919

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Nov 29, 2022
View reviewed changes
pkgs/development/python-modules/modeled/default.nix
@@ -21,8 +22,14 @@ buildPythonPackage rec {

buildInputs = [ zetup ];

nativeBuildInputs = [ pythonRemoveDepsHook ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ pythonRemoveDepsHook ];
nativeBuildInputs = [ pythonRelaxDepsHook ];

pkgs/development/python-modules/modeled/default.nix
@@ -7,6 +7,7 @@
, moretools
, path
, pytestCheckHook
, pythonRemoveDepsHook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, pythonRemoveDepsHook
, pythonRelaxDepsHook

@applePrincess
Copy link
Contributor Author

After applying the suggestion, I could not get to build. I was too happy to pass nixpkgs-review wip (no packages were built) and create this PR. I was investigating a little further

after disabling tests, it builds. However, zetup is required at runtime and its version check occurs when module medeled is imported. The check needs __version__ variable in __init__.py of path package which fails.

@applePrincess applePrincess marked this pull request as draft November 29, 2022 18:17
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2023
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@applePrincess @SuperSandro2000 @wegank