Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.sh: disable flaky tests #199441

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 4, 2022

Description of changes

Closes #199438.

Also, ZHF #199919

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@siriobalmelli
Copy link
Contributor

Result of nixpkgs-review pr 199441 run on x86_64-darwin 1

@siriobalmelli
Copy link
Contributor

LGTM

Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason disabledTests doesn't work?

@wegank
Copy link
Member Author

wegank commented Nov 5, 2022

@toonn The package uses unittest instead of pytest, so disabledTests won't work.

@wegank wegank requested a review from toonn November 5, 2022 20:59
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1356

Copy link
Contributor

@toonn toonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. If unittest isn't compatible with disabledTests a patch seems like a good solution.

@mweinelt
Copy link
Member

mweinelt commented Nov 7, 2022

Pytest is compatible with unittest, so you can use pytestCheckHook instead with pytestFlagsArray = [ "test.py" ];. Then you can use disabledTests and purge the patch files.

@wegank
Copy link
Member Author

wegank commented Nov 7, 2022

@mweinelt Done. Although this will surely lead to massive rebuilds.

@mweinelt
Copy link
Member

mweinelt commented Nov 7, 2022

Then please rebase onto staging-next for this one time. I'll set this PR to draft to prevent accidental review requests.

@mweinelt mweinelt marked this pull request as draft November 7, 2022 12:51
@wegank wegank changed the base branch from master to staging-next November 7, 2022 13:23
@wegank
Copy link
Member Author

wegank commented Nov 7, 2022

@mweinelt Rebased.

@mweinelt mweinelt marked this pull request as ready for review November 7, 2022 13:36
@mweinelt mweinelt merged commit 5134699 into NixOS:staging-next Nov 7, 2022
@wegank wegank deleted the sh-aarch64-darwin branch November 7, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3Packages.sh fails to build on Hydra (aarch64-darwin)
5 participants