-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.sh: disable flaky tests #199441
Conversation
4896cd3
to
1a2d5e6
Compare
Result of |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason disabledTests
doesn't work?
@toonn The package uses unittest instead of pytest, so |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1356 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. If unittest
isn't compatible with disabledTests
a patch seems like a good solution.
Pytest is compatible with unittest, so you can use |
1a2d5e6
to
9f6909e
Compare
@mweinelt Done. Although this will surely lead to massive rebuilds. |
Then please rebase onto |
9f6909e
to
370c1a9
Compare
@mweinelt Rebased. |
Description of changes
Closes #199438.
Also, ZHF #199919
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes