Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boehmgc: disabled tests on powerpc64le-linux #198591

Closed
wants to merge 1 commit into from

Conversation

jiegec
Copy link
Contributor

@jiegec jiegec commented Oct 30, 2022

Description of changes

See ivmai/bdwgc#376, the upstream bug has not been fixed.

Things done
  • Built on platform(s)
    • x86_64-linux
    • powerpc64le-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge this.

The problem on Darwin is caused by the Rosetta emulator; it has nothing to do with the powerpc64le situation:

#191339 (comment)

The test failure isn't a false positive.

Disabling the tests here is risky. Remember that Nix itself uses boehm-gc.

I'm filing another PR that disables the optimization which is causing the tests to fail. Github won't let me ```suggest it here because it touches parts of the file which are more than three lines away from your changes.

@ghost
Copy link

ghost commented Nov 7, 2022

Please consider #199978 instead.

@ghost ghost mentioned this pull request Nov 7, 2022
13 tasks
@jiegec
Copy link
Contributor Author

jiegec commented Nov 7, 2022

Closed in favor of #199991 199978

@jiegec jiegec closed this Nov 7, 2022
@jiegec jiegec deleted the boehmgc-ppc64le branch November 7, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants