qcoro: 0.4.0 -> 0.6.0 and AArch64 fix #196047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Alternative for #185191. I preferred opening a new PR instead of "rudely" changing the semantics of the other PR.
See #185191 (comment)
The TLDR is it is also fixing the packages using qcoro, otherwise they still wouldn't build even though qcoro itself would build. Also changed the fix to use
gcc11Stdenv
, as suggested by @SuperSandro2000 here.Things done
I tested with #193858, on x86_64 and AArch64, native builds for both.
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesCloses #185191