Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: revert withdrawn releases #195828

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Oct 13, 2022

Description of changes

https://mta.openssl.org/pipermail/openssl-announce/2022-October/000237.html

also https://www.openssl.org/source/openssl-1.1.1r.tar.gz 404s now

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from mweinelt October 13, 2022 16:12
@mweinelt mweinelt merged commit 5216997 into NixOS:staging Oct 13, 2022
@ajs124 ajs124 deleted the revert/openssl branch October 13, 2022 16:18
@LunNova
Copy link
Member

LunNova commented Oct 13, 2022

https://www.openssl.org/source/openssl-3.0.6.tar.gz is 404ing now, hopefully this doesn't take too long to get to master from staging.

@LunNova
Copy link
Member

LunNova commented Oct 13, 2022

Since it's a revert is it safe to bring it to master immediately without worrying about mass rebuilds?

@ajs124
Copy link
Member Author

ajs124 commented Oct 13, 2022

iirc the reverted commits never made it to master from staging

@mweinelt
Copy link
Member

openssl.org/source/openssl-3.0.6.tar.gz is 404ing now, hopefully this doesn't take too long to get to master from staging.

The releases were withdrawn, hence the revert.

Since it's a revert is it safe to bring it to master immediately without worrying about mass rebuilds?

They're both mass rebuilds, so they have to go through staging. Also the releases were not really security relevant.

@LunNova
Copy link
Member

LunNova commented Oct 13, 2022

Ah, missed that this never made it to master, that's nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants