Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] sage: update test expectations (sympy and ipywidgets upgrades) #192832

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

collares
Copy link
Member

@collares collares commented Sep 24, 2022

Description of changes

Sympy and ipywidgets were upgraded in 81ab49a and cfe3eab, which are currently on staging-next. The ipywidgets patch has not been reviewed upstream yet, but it looks OK. The staging-next PR (#191339) was opened on the 15th, and I assume there is some chance it will be merged in the next week, so arguably we shouldn't wait for upstream review. If we merge the present PR, I'll make sure we have an updated patch once it gets included into a Sage beta.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@collares
Copy link
Member Author

collares commented Sep 24, 2022

As has been the case since June, Sage tests are broken on aarch64. It seems like the GAP update (#192548) will fix that, but there are some remaining packaging issues to be dealt with. It's all a bit spooky because the last GAP update was in May 2021 and the deadlocks started happening in June 2022, but I'll take it :) Probably some strange interaction between a nondeterministic GC bug fixed in GAP 4.12.0 and some hardware/kernel change.

Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the patches and upstream (mainly SageMath and SymPy) discussions.

The changes to SymPy test cases are not obvious, but they happened due to degrees of freedom in symbolic computation and the differences are expected according to upstream conclusion. All changes are adjustment of expected outputs in test cases and no impacts to the packages' functionalities.

Thank you for your effort, @collares!

@collares
Copy link
Member Author

Thanks for the review!

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timokau timokau merged commit e453c6b into NixOS:staging-next Sep 25, 2022
@collares collares deleted the sage-ipywidgets branch January 26, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants