mepo: 0.4.2 -> 0.5

[ghost]

Description of changes

First commit is a simple version bump.

Second commit adds gpsd as an optional dependency and points mepo's scripts' gpspipe to the correct path. It also makes silent reporting of the user's location to Mozilla and geoclue opt-in rather than opt-out; this issue has been reported upstream to request a build flag so we don't have to use patches.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[ghost]

Added commits which were formerly part of #189345.

[McSinyx]

Path to GeoClue binaries need substitution and IMHO Mozilla location service should be conditionally enabled in the same manner as the others. BTW you should rebase the commits for each to be meaningful (GitHub suggestion should be read-only).

[ghost]

Path to GeoClue binaries need substitution

Done: 3b8d39d136de50cfd3b0e3159cb0b2b318b67565

and IMHO Mozilla location service should be conditionally enabled in the same manner as the others.

I don't understand what you mean... isn't reportLocationToMozilla conditionally enabling the mozilla location service?

BTW you should rebase the commits for each to be meaningful (GitHub suggestion should be read-only).

I don't understand this either... what do you mean by meaningful? And what GitHub suggestion?

[McSinyx]

isn't reportLocationToMozilla conditionally enabling the mozilla location service?

It is, apologies, I misread 😅

what do you mean by meaningful [commit]?

37ceaf7d4c5c1157b3eb51262d520fc0ec0cdb77 and 3b8d39d136de50cfd3b0e3159cb0b2b318b67565 are examples of commits that only make sense with the context of the discussion. Each commit should make sense by itself should it be merged.

what GitHub suggestion?

The one created 37ceaf7d4c5c1157b3eb51262d520fc0ec0cdb77.

[ghost]

37ceaf7 and 3b8d39d are examples of commits that only make sense with the context of the discussion. Each commit should make sense by itself should it be merged.

Oh, I see, you want me to squash the history to clean it up. Sure, no problem.

Each commit should make sense by itself should it be merged.

Right. Just to be clear though, I don't think it is a good idea to merge the version bump without the user location protection. I will squash the history into two commits, but I hope that either both of them or else neither of them is merged.

[McSinyx]

Thanks! GitHub UX kinda only allows merging all or nothing (unless a maintainer pushes to your remote which is too spooky IMHO), hence often quite some nitpick round trips are needed.

[ghost]

Thanks! GitHub UX kinda only allows merging all or nothing

Ah, interesting; I did not know that. I have plenty of complaints about github :)

hence often quite some nitpick round trips are needed.

No problem. Should be squashed now into four separate topic-specific commits at 8981daa. This should make things easier down the line if one of them needs to be reverted.

[McSinyx]

Working as expected for me.

[sikmir]

Result of nixpkgs-review pr 189344 run on x86_64-linux 1

2 packages built:

• mepo
• mepo-x11

[sikmir]

I guess .orig file should not be installed:

$ ls results/mepo/bin/*.orig
results/mepo/bin/mepo_ui_menu_user_pin_updater.sh.orig

[SuperSandro2000]

Suggested change

	, geoclueSupport ? false , geoclue2
	# transmits user's location without asking first
	, reportLocationToMozilla ? false
	, gpsdSupport ? true , gpsd
	, geoclueSupport ? false, geoclue2
	# transmits user's location without asking first
	, reportLocationToMozilla ? false
	, gpsdSupport ? true, gpsd

Shouldn't we assert something here? not sure what tbh

[ghost]

Shouldn't we assert something here?

Why?

[SuperSandro2000]

Would it work to turn all on or off?

[ghost]

Correct: all 2^3 combinations of the three boolean flags are valid.

[ghost]

I guess .orig file should not be installed:

$ ls results/mepo/bin/*.orig
results/mepo/bin/mepo_ui_menu_user_pin_updater.sh.orig

I'm trying to reproduce this.

We might need --no-backup-if-mismatch in patchFlags. I'm surprised that isn't the default.

[ghost]

So, based on upstream's response it doesn't look like there is an easy solution, and my concerns will likely recur in future version bumps.

I'll let the package maintainers @sikmir @McSinyx decide what to do here. Feel free to use some/all/none of the changes in this PR.