Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: extendMkDerivationArgs: support mkDerivation (_: ...) from #119942 #185077

Closed
wants to merge 1 commit into from
Closed

stdenv: extendMkDerivationArgs: support mkDerivation (_: ...) from #119942 #185077

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2022

Description of changes

I've had this in my local tree for almost two months now; I kinda assumed somebody else would've been forced to merge a similar fix by now but I guess not. Having to make this fix after a rebase was how I discovered the new pass-a-function-to-mkDerivation feature!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • powerpc64le-linux
    • mips64el-linux
  • Tested compilation of all many packages that depend on this change
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Aug 4, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/proposal-move-values-from-derivation-attributes-to-function-arguments/20697/14

@ghost
Copy link
Author

ghost commented Aug 5, 2022

Ah, this got fixed by #176385.

@ghost ghost closed this Aug 5, 2022
@ghost ghost deleted the pr/stdenv/overlay-args branch January 23, 2024 06:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant