setserial: fix cross compilation #182169
Merged
setserial: fix cross compilation #182169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winterqt
approved these changes
Jul 20, 2022
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
winterqt
requested changes
Jul 20, 2022
There was a problem hiding this comment.
Change looks good, but on a closer glance, I'm not sure if I like the commit message wording. This is very nitpicky (and I'm sorry, if you feel like this nit is unjustified, feel free not to not make any further changes and I'll merge anyways), but wouldn't it make more sense to say something loke "a native build dependency" instead of "a nativeBuildDependencies" in the commit description, especially considering the fact that the key is nativeBuildInputs (as opposed to it being nativeBuildDependencies)?
Let me know what you think, thanks.
Yes, you're right. Fixed. |
ghost
requested a review
from The setserial derivation uses nroff at compile time, so groff should be in nativeBuildInputs rather than buildInputs.
trofi
approved these changes
Jul 20, 2022
1 task
|
Successfully created backport PR #182224 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The setserial derivation uses nroff at compile time, so groff should be a nativeBuildDependencies.
Things done
./result/bin/)