Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: turn configureFlags into a sigle list, not nested list #181999

Merged
merged 1 commit into from
Jul 20, 2022
Merged

gcc: turn configureFlags into a sigle list, not nested list #181999

merged 1 commit into from
Jul 20, 2022

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jul 18, 2022 •
edited
Loading

Before the change:

$ nix repl pkgs/stdenv/linux/make-bootstrap-tools-cross.nix
nix-repl> :p powerpc64le.bootGCC.configureFlags
[ ... "--enable-targets=powerpcle-linux" [ "--with-long-double-128" ] "--target=powerpc64le-unknown-linux-gnu" ]

After the change:

nix-repl> :p powerpc64le.bootGCC.configureFlags
[ ... "--enable-targets=powerpcle-linux" "--with-long-double-128" "--target=powerpc64le-unknown-linux-gnu" ]
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
gcc: turn configureFlags into a sigle list, not nested list
69da37a 
Before the change:

    $ nix repl pkgs/stdenv/linux/make-bootstrap-tools-cross.nix
    nix-repl> :p powerpc64le.bootGCC.configureFlags
    [ ... "--enable-targets=powerpcle-linux" [ "--with-long-double-128" ] "--target=powerpc64le-unknown-linux-gnu" ]

After the change:

    nix-repl> :p powerpc64le.bootGCC.configureFlags
    [ ... "--enable-targets=powerpcle-linux" "--with-long-double-128" "--target=powerpc64le-unknown-linux-gnu" ]
@trofi trofi requested a review from matthewbauer as a code owner July 18, 2022 18:16
@trofi trofi mentioned this pull request Jul 18, 2022
Closed
3 tasks
@trofi
Copy link
Contributor Author

trofi commented Jul 20, 2022

Merging as an obvious no-op.

@trofi trofi merged commit cb63ee9 into NixOS:master Jul 20, 2022
@trofi trofi deleted the gcc-clean-up-configureFlags branch July 20, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trofi