Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: drop outdated sed for system headers clobber #181994

Merged
merged 1 commit into from
Jul 24, 2022

Commits on Jul 18, 2022

  1. gcc: drop outdated sed for system headers clobber

    When reviewing NixOS#181802 (comment)
    I noticed outdated code that attempted to override /usr/include.
    
        sed -i \
            -e "s,glibc_header_dir=/usr/include,glibc_header_dir=$libc_dev/include", \
            gcc/configure
    
    `glibc_header_dir` was removed from `gcc-4.6` and later in
    https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=6961669f48aa18168b2d7daa7e2235fbec7cb636
    (Dec 2010, "(gcc_cv_ld_eh_frame_hdr): Only check GNU ld for  --eh-frame-hdr.").
    
    Since then gcc got `--with-native-system-header-dir=` which `nixpkgs` uses
    for all packaged `gcc` versions.
    
    The change should be a no-op.
    trofi committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    769956d View commit details
    Browse the repository at this point in the history