Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE THIS #180036

Closed
wants to merge 2 commits into from
Closed

DO NOT MERGE THIS #180036

wants to merge 2 commits into from

Commits on Jul 3, 2022

  1. check-meta.nix: make non-source consistent with documentation 

    The documentation for `meta.sourceProvenance` in
`doc/stdenv/meta.chapter.md` says: "the `meta.sourceProvenance`
attribute should be a list containing one or more value..."

Let's update check-meta.nix to require that `meta.sourceProvenance` is
a list, as the documentation says, rather than a single element.

Adding two extra keystrokes `[` and `]` when filling out this field is
an insignificant burden for package authors, and being able to assume
that the `meta.sourceProvenance` field is always a list greatly
simplifies any code that acts on the value of this field.

Since `meta.sourceProvenance` was just merged a few hours ago now is
the easiest time to fix this: nobody is using the feature yet.
    Adam Joseph committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    7883af8 View commit details
    Browse the repository at this point in the history

  2. hello: add invalid sourceProvenance

    Adam Joseph committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    d2afb54 View commit details
    Browse the repository at this point in the history