pkgsMusl.colord: fix build #179682
Merged
pkgsMusl.colord: fix build #179682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jun 30, 2022
As far as I can tell, none of the colord applications are graphical. This change is important for Musl, where librsvg is not supported because rustc does not support dynamically-linked Musl[1]. [1]: NixOS#179242
|
Doesn't build due to having recently acquired a transitive dependency of gperftools, which is currently broken on Musl. Will be fixed by #179102 due to it upgrading gperftools. |
jtojnar
reviewed
Jul 1, 2022
We can't build the daemon in pkgsMusl, because rustc does not support dynamic Musl targets[1]. But it still makes sense to support the rest of colord, because an application should still be able to link against it to talk to a colord daemon built in some other way (e.g. provided by a different distro). [1]: NixOS#179242
jtojnar
approved these changes
Jul 1, 2022
|
Sigh. OfBorg lib tests have failed due to a curl test failure. Let's try again. @ofborg eval |
bobby285271
added
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We can't build the daemon in pkgsMusl, because rustc does not support dynamic Musl targets, which means we can't build Spidermonkey, which means we can't build Polkit. But it still makes sense to support the rest of colord, because an application should still be able to link against it to talk to a colord daemon built in some other way (e.g. provided by a different distro).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes