Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: mark broken for dynamic Musl target #179554

Merged
merged 1 commit into from
Jul 2, 2022
Merged

rustc: mark broken for dynamic Musl target #179554

merged 1 commit into from
Jul 2, 2022

Conversation

alyssais
Copy link
Member

Description of changes

See #179242.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested review from Mic92, LnL7 and zowoq as code owners June 29, 2022 10:24
@alyssais alyssais added 6.topic: musl Running or building packages with musl libc 6.topic: rust backport release-22.05 labels Jun 29, 2022
@alyssais alyssais requested review from wyndon and yu-re-ka June 29, 2022 10:24
@alyssais alyssais mentioned this pull request Jun 29, 2022
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 29, 2022
@alyssais alyssais merged commit 6f9359a into NixOS:master Jul 2, 2022
@alyssais alyssais deleted the rustc-musl branch July 2, 2022 09:08
@github-actions github-actions bot mentioned this pull request Jul 2, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

Successfully created backport PR #179884 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq zowoq approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@LnL7 LnL7 Awaiting requested review from LnL7

@wyndon wyndon Awaiting requested review from wyndon

@yu-re-ka yu-re-ka Awaiting requested review from yu-re-ka

Assignees
No one assigned
Labels
6.topic: musl Running or building packages with musl libc 6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssais @zowoq