Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lima: add wrapper and lima-unwrapped #179521

Closed
wants to merge 2 commits into from

Conversation

tricktron
Copy link
Member

Description of changes

colima 0.4.1 on master is currently broken because the vm has no internet access: abiosoft/colima#344

colima needs direct access to the unwrapped lima binary to fix it. This pr adds the lima-unwrapped derivation for it.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tricktron
Copy link
Member Author

@ofborg build lima

@aaschmid aaschmid self-requested a review June 29, 2022 19:09
@aaschmid
Copy link
Contributor

Would work for me in conjunction with #179522 (even though it seems that there are discussions if this is necessary).

@abiosoft
Copy link

This may not be needed anymore #179522 (comment), except there are other benefits of this in the long run.

Really appreciative of your efforts @aaschmid and @tricktron.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 30, 2022
@tricktron tricktron marked this pull request as draft July 1, 2022 05:09
@tricktron
Copy link
Member Author

Colima works now with the wrapper and the unwrapped is thus not needed anymore. Closed.

@tricktron tricktron closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants