webkitgtk: set -DENABLE_JOURNALD_LOG=OFF if !systemdSupport #179391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we get this build failure: -- Could NOT find Journald (missing: Journald_LIBRARY Journald_INCLUDE_DIR) CMake Error at Source/cmake/OptionsGTK.cmake:486 (message): libsystemd or libelogind are needed for ENABLE_JOURNALD_LOG Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:220 (include) CMakeLists.txt:20 (include) -- Configuring incomplete, errors occurred! See also "/build/webkitgtk-2.36.0/build/CMakeFiles/CMakeOutput.log". See also "/build/webkitgtk-2.36.0/build/CMakeFiles/CMakeError.log".
ofborg
bot
requested review from
hedning,
jtojnar,
dasj19,
amaxine and
bobby285271
|
Ping... |
1 similar comment
|
Ping... |
|
Did not test, can we also remove |
Indeed, we can. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When
webkitgtkis built withsystemdSupport=falsethe following build failure occurs:Let's add
-DENABLE_JOURNALD_LOG=OFFif!systemdSupportin order to fix this.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)